dweiss commented on PR #14764: URL: https://github.com/apache/lucene/pull/14764#issuecomment-2965807030
> Hope you don't mind me chiming in as this PR catched my attention. I'm Rene and maintain the elasticsearch gradle build and have been involved with Gradle directly since 0.4. I added a few remarks. I know who you are, @breskeby (from mailing lists googling for answers...) :) Thank you for jumping in! I would love to draw from your experience because - I admit - I am quite lost with those new gradle developments... the first versions had a lot of appeal to me but seemed a lot more intuitive... A graph of tasks/ projects and stuff applied across this graph. One of the things you mentioned is probably the primary thing I struggle with - the subprojects/ allprojects block. The entire idea of Lucene's build logic was based on applying separate concerns across all affected projects. How are you expected to do it without these features? What is the "proper way"? > In general I think those convention plugins are still quite heavy. by that I mean they contain a lot imperative build logic. Usually those convention plugins are meant to be small and simple One of the reasons for using convention plugins was to keep those "build aspects" separate and easy to identify. I do plan to move to java code, eventually, but this is a technicality - it doesn't solve the problems/ issues I currently have trouble with solving (like the insanity of tracking lazy evaluation cross-dependencies)... If you do have time to help out, it would be great if you took an example small bit and tried to fix it "the right way" - perhaps after this patch is committed, so we all can learn how it should be done and follow your tracks. It'd be also great if I (or we) could ask for your review on smaller gradle patches - this would be a great way for me to improve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
