breskeby commented on code in PR #14764:
URL: https://github.com/apache/lucene/pull/14764#discussion_r2142114663


##########
build-tools/build-infra/src/main/groovy/lucene.java-projects.conventions.gradle:
##########
@@ -15,15 +15,20 @@
  * limitations under the License.
  */
 
-// Configure release artifact signing.
+allprojects { project ->

Review Comment:
   (excessive) usage of allprojects within convention plugins should be 
avoided. It will break the ability to move towards isolated project. Instead 
conventions plugins should be applied on the actual project. Be careful with 
using allprojects and subprojects usages across the build



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to