kaivalnp commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2954666179
Thank you for the review @mikemccand, super helpful ! I've tried to incorporate all changes, and made some other fixes / refactors as well ! As a follow up, could you allow the [`mamba-org/setup-micromamba`](https://github.com/mamba-org/setup-micromamba) GH action to run on the Lucene repository -- so that the Faiss codec can be tested regularly? (we need `micromamba` to pull Faiss libraries from Conda, as a faster alternative to `miniconda`, `miniforge`, etc). It can be done from `Settings > Code and automation > Actions > General > Actions permissions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
