jpountz commented on code in PR #14716: URL: https://github.com/apache/lucene/pull/14716#discussion_r2120387948
########## lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java: ########## @@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator { */ public static final short ALL = OFFSETS | PAYLOADS; + /** + * Flag to pass to {@link TermsEnum#postings(PostingsEnum, int)} to get impacts in the returned + * enum. + */ + public static final short IMPACTS = FREQS | 1 << 7; Review Comment: After a few iterations on wikibigall, it seems to work fine with the current codec. However it looks challenging to apply correctly to old codecs, which use a different PostingsEnum impl when impacts are requested, and that I'd like to avoid touching too much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org