jpountz commented on code in PR #14716: URL: https://github.com/apache/lucene/pull/14716#discussion_r2120389716
########## lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java: ########## @@ -63,6 +87,12 @@ public abstract class PostingsEnum extends DocIdSetIterator { */ public static final short ALL = OFFSETS | PAYLOADS; + /** + * Flag to pass to {@link TermsEnum#postings(PostingsEnum, int)} to get impacts in the returned + * enum. + */ + public static final short IMPACTS = FREQS | 1 << 7; Review Comment: I imagine that having a flag also has some benefits, e.g. some impls could decide to store impacts in a separate file in the future and only open this file if impacts are requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org