vigyasharma commented on PR #14009:
URL: https://github.com/apache/lucene/pull/14009#issuecomment-2903244426

   > For the alternative implementation we leave that up to the final hit 
collection to return the top-k based on a ranking mechanism
   
   Those final TopDocs collectors will use the score generated by the Rerank 
query, which is the rerank mechanism we are implementing.
   
   I'm not really sure I follow the concern here. In both cases, you need to 
score all the docs to find top-K. In this one, you do it during rewrite and 
maintain your own HitQueue. In the other, you do it in Scorer and leverage 
TopDocs collector or whatever collector is needed. The alternate approach is 
more flexible, you can vary how many hits you want to work with (upto 
oversample limit). But computationally, it's not more expensive.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to