dungba88 commented on PR #14009: URL: https://github.com/apache/lucene/pull/14009#issuecomment-2901114417
No worry, I think generalization makes sense to me too. And I like the idea of moving this forward. The use of `KnnFloatVectorQuery` in this implementation only adds a small benefit that we can short-circuit when the results are less than k, which is marginal to be honest. Totally agree that we can make it a generic Query. I'm not sure about the weight part though. Asking just for my understanding of Lucene, I thought Lucene typically rewrites the Query first, and then createWeight on the simplest form. Here we are doing the reverse (createWeight, and inside that call rewrite). Can this break any assumption (e.g caching) in Lucene? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
