jpountz commented on code in PR #14529:
URL: https://github.com/apache/lucene/pull/14529#discussion_r2058189258
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##########
@@ -693,6 +723,34 @@ boolean advanceExactWithinBlock(IndexedDISI disi, int
target) throws IOException
disi.index = disi.numberOfOnes - Long.bitCount(leftBits);
return (leftBits & 1L) != 0;
}
+
+ @Override
+ boolean intoBitSetWithinBlock(IndexedDISI disi, int upTo, FixedBitSet
bitSet, int offset)
+ throws IOException {
+ if (disi.bitSet == null) {
+ disi.bitSet = new FixedBitSet(BLOCK_SIZE);
+ }
+
+ int sourceFrom = disi.doc & 0xFFFF;
+ int sourceTo = Math.min(upTo - disi.block, BLOCK_SIZE);
+ int destFrom = disi.block - offset + sourceFrom;
Review Comment:
Is this the same as `disi.doc - offset`?
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##########
@@ -693,6 +723,34 @@ boolean advanceExactWithinBlock(IndexedDISI disi, int
target) throws IOException
disi.index = disi.numberOfOnes - Long.bitCount(leftBits);
return (leftBits & 1L) != 0;
}
+
+ @Override
+ boolean intoBitSetWithinBlock(IndexedDISI disi, int upTo, FixedBitSet
bitSet, int offset)
+ throws IOException {
+ if (disi.bitSet == null) {
+ disi.bitSet = new FixedBitSet(BLOCK_SIZE);
+ }
+
+ int sourceFrom = disi.doc & 0xFFFF;
+ int sourceTo = Math.min(upTo - disi.block, BLOCK_SIZE);
+ int destFrom = disi.block - offset + sourceFrom;
+
+ long fp = disi.slice.getFilePointer();
+ disi.slice.seek(fp - Long.BYTES);
Review Comment:
nit: maybe leave a small comment explaining why we're seeking backwards, I
believe that it's to include the word that contains the current doc, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
