gf2121 commented on code in PR #14529:
URL: https://github.com/apache/lucene/pull/14529#discussion_r2057923869
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##########
@@ -693,6 +727,44 @@ boolean advanceExactWithinBlock(IndexedDISI disi, int
target) throws IOException
disi.index = disi.numberOfOnes - Long.bitCount(leftBits);
return (leftBits & 1L) != 0;
}
+
+ @Override
+ boolean intoBitSetWithinBlock(IndexedDISI disi, int upTo, FixedBitSet
bitSet, int offset)
+ throws IOException {
+ if (disi.doc >= upTo) {
+ advanceWithinBlock(disi, disi.doc);
Review Comment:
This was useful before we advancing `disi.block`, but not now. I like the
simplification more :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
