gf2121 commented on code in PR #14529:
URL: https://github.com/apache/lucene/pull/14529#discussion_r2058000145
##########
lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestIndexedDISI.java:
##########
@@ -555,6 +565,47 @@ private void assertAdvanceExactRandomized(
}
}
+ private void assertIntoBitsetRandomized(
+ IndexedDISI disi, BitSetIterator disi2, int disi2length, int step)
throws IOException {
+ int index = -1;
+ FixedBitSet set1 = new FixedBitSet(step);
+ FixedBitSet set2 = new FixedBitSet(step);
+
+ for (int upTo = 0; upTo < disi2length; ) {
+ int lastUpTo = upTo;
+ upTo += TestUtil.nextInt(random(), 0, step);
+ int offset = TestUtil.nextInt(random(), lastUpTo, upTo);
+
+ if (disi.docID() < offset) {
+ disi.advance(offset);
+ }
+ int doc = disi2.docID();
+ while (doc < offset) {
+ index++;
+ doc = disi2.nextDoc();
+ }
+ while (doc < upTo) {
+ set2.set(doc - offset);
+ index++;
+ doc = disi2.nextDoc();
+ }
+
+ disi.intoBitSet(upTo, set1, offset);
+ assertEquals(index, disi.index());
+ BitSetIterator expected = new BitSetIterator(set2, set2.cardinality());
+ BitSetIterator actual = new BitSetIterator(set1, set1.cardinality());
+ for (int expectedDoc = expected.nextDoc();
+ expectedDoc != DocIdSetIterator.NO_MORE_DOCS;
+ expectedDoc = expected.nextDoc()) {
+ int actualDoc = actual.nextDoc();
+ assertEquals(expectedDoc + offset, actualDoc + offset); // plus offset
for better message.
+ }
+ assertEquals(DocIdSetIterator.NO_MORE_DOCS, actual.nextDoc());
+ set1.clear();
+ set2.clear();
Review Comment:
This helps me find a bug: `upTo` could be a number in last block when
`RANGE` do `intoBitSetWithinBlock`, i'm missing a `doc > upTo` check there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
