jainankitk commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2762048902
> You just need to replace ctx with _.
Ah, my bad! I tried `.`, but we can't use that as part of variable name.
Thanks for the suggestion @jpountz.
At a high level, I have unified the concurrent/non-concurrent profiling
paths as suggested. The `QueryProfilerTree` is shared across slices, and we
recursively build the ProfilerTree for each slice for response. There are few
kinks that we still need to be iron out. For example:
* `Weight` creation is global across slices. How do we account for its time?
Should be have separate global tree with just the weight times? We can't just
get away with having weight count at the top as `Weight` is shared for child
queries as well, right?
* The new in-memory structure for profiled queries is bit like below (notice
additional list for slices):
```
"query": [ <-- for list of slices
[ <-- for list of root queries
{
"type": "TermQuery",
"description": "foo:bar",
"time_in_nanos" : 11972972,
"breakdown" :
{
```
We can probably have map of slices, with key being the `sliceId`:
```
"query": {
"some global information":
"slices": {
"slice1": [ <-- for list of root queries
{
"type": "TermQuery",
"description": "foo:bar",
"time_in_nanos" : 11972972,
"breakdown" :
{...}}],
"slice2": [],
"slice3": []}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
