jpountz commented on PR #14401: URL: https://github.com/apache/lucene/pull/14401#issuecomment-2761666414
Any opinion on `collect(int min, int max)` vs. `collectRange(int min, int max)`? I leaned towards `collectRange` since we already have `collect(int doc)` and it wouldn't be obvious from the parameter types whether `collect(int, int)` is collecting a range or two random docs. No strong feeling either way though. `collect(DocIdStream)` is called "collect" rather than "collectDocIdStream" so I guess that `collect(int min, int max)` would be more consistent from this perspective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
