gf2121 commented on code in PR #14401:
URL: https://github.com/apache/lucene/pull/14401#discussion_r2018024992
##########
lucene/core/src/java/org/apache/lucene/search/LeafCollector.java:
##########
@@ -83,6 +84,21 @@ public interface LeafCollector {
*/
void collect(int doc) throws IOException;
+ /**
+ * Collect a range of doc IDs, between {@code min} inclusive and {@code max}
exclusive.
+ *
+ * <p>Extending this method is typically useful to take advantage of
pre-aggregated data exposed
+ * in a {@link DocValuesSkipper}.
+ *
+ * <p>The default implementation calls {@link #collect(DocIdStream)} on a
{@link DocIdStream} that
Review Comment:
Maybe clarify if we have any guarantee on the given values like `max > min` ?
##########
lucene/core/src/java/org/apache/lucene/search/RangeDocIdStream.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.search;
+
+import java.io.IOException;
+
+final class RangeDocIdStream extends DocIdStream {
+
+ private final int min, max;
+
+ RangeDocIdStream(int min, int max) {
+ if (max < min) {
Review Comment:
Do we intend to allow `min==max`, which is actually an empty range? We need
to update this or the exception message anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
