vigyasharma commented on code in PR #14173: URL: https://github.com/apache/lucene/pull/14173#discussion_r2008411867
########## lucene/core/src/java/org/apache/lucene/util/hnsw/UpdatableScoreHeap.java: ########## Review Comment: I'd like to keep the logic to update scores for already ingested docs encapsulated within the heap. By returning the array index within the heap (the LongHeap changes in #12314), we shift this responsibility to consumers, like the [NeighborQueue changes](https://github.com/apache/lucene/blob/1523ee796a6d35a7d92532590458b2a2d8dd9e4b/lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java#L99-L113), which can be trappy and cause repeated code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
