benwtrent commented on PR #14173:
URL: https://github.com/apache/lucene/pull/14173#issuecomment-2621652581

   > For parentJoin benchmark run on main, there is a visible drop in recall 
when I disable merges (as compared to a main branch run with merges enabled). 
Is this expected?
   
   I wonder if you are comparing vector IDs correctly?
   
   Looking at the "merges enabled/disabled" it doesn't make sense to me as one 
would be better than the other as both are then force-merged into a single 
segment.
   
   I also don't understand the recall change between parentJoin on main vs. 
parentJoin in your branch. That is a significant difference, which seems like 
there is a bug in the test runner or in the code itself.
   
   These numbers indeed confuse me. Maybe there is a bug in sparse vector index 
handling?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to