stefanvodita commented on code in PR #14326:
URL: https://github.com/apache/lucene/pull/14326#discussion_r1984194652
##########
dev-tools/scripts/releaseWizard.py:
##########
@@ -887,7 +873,7 @@ def get_release_version():
version = Version.parse(v)
except Exception:
print("Not a valid version %s" % v)
- return get_release_version()
+ raise
Review Comment:
It's hard for me to judge this one without knowing how it's used, but I can
imagine it's frustrating to stop a long workflow with this exception because of
a typo instead of prompting the user a second time. Now, from looking at the
code, it seems that is not the case, so it should be fine to proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
