rmuir commented on code in PR #14326:
URL: https://github.com/apache/lucene/pull/14326#discussion_r1984178330
##########
dev-tools/scripts/releaseWizard.py:
##########
@@ -887,7 +873,7 @@ def get_release_version():
version = Version.parse(v)
except Exception:
print("Not a valid version %s" % v)
- return get_release_version()
+ raise
Review Comment:
I know when battling this one, it was difficult to fix the issues because of
situations like this. It causes helper function `get_release_version()` to have
unnecessarily wide type (e.g. allowing None or maybe even other types in some
places). And callsites are not checking for those exceptional cases, which
makes for tons of chaos.
Better for exceptional cases to be exceptions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
