rmuir commented on code in PR #14326: URL: https://github.com/apache/lucene/pull/14326#discussion_r1984174681
########## dev-tools/scripts/releaseWizard.py: ########## @@ -887,7 +873,7 @@ def get_release_version(): version = Version.parse(v) except Exception: print("Not a valid version %s" % v) - return get_release_version() + raise Review Comment: I think some of the change was automatic. What else should we do if supplied with an invalid version? try to proceed anyway? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org