epotyom commented on code in PR #14237: URL: https://github.com/apache/lucene/pull/14237#discussion_r1960081192
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/utils/CommonFacetBuilder.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.sandbox.facet.utils; + +import java.io.IOException; +import org.apache.lucene.sandbox.facet.cutters.FacetCutter; +import org.apache.lucene.sandbox.facet.labels.OrdToLabel; + +/** + * Common {@link FacetBuilder} that works with any {@link FacetCutter} and {@link OrdToLabel} + * provided by user. + */ +public final class CommonFacetBuilder extends BaseFacetBuilder<CommonFacetBuilder> { Review Comment: BaseFacetBuilder is abstract package-private class that implements common functionality that different FacetBuilder implementations can reuse. CommonFacetBuilder is a final class, kind of generic facet builder that can be used with any FacetCutter, but as a consequence it lacks some facet type specific functionality. E.g. using it for taxonomy facets makes sense only if we don't need to specify parent path and don't need to compute overall value. The idea is that creating FacetBuilder should not be required for every facet type, just for the types that require some custom logic, such as taxonomy facets. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
