epotyom commented on PR #14237: URL: https://github.com/apache/lucene/pull/14237#issuecomment-2662789904
Thanks for reviewing @stefanvodita ! > I have some non-blocking concerns that this is a lot of new code, with more abstractions, and it doesn't have a user waiting to use it. There are arguments against those concerns as well and I personally like the new aggregations, but I thought it was worth raising the point. I agree with the concern, at the same time it might be one of these chicken and egg cases when users avoid using the feature just because it doesn't have simple enough API for simple use cases? One use case for the new utils I have in mind is luceneutil perf tests - it puts me off that [we need 90 lines](https://github.com/mikemccand/luceneutil/blob/dac76d58c579bf440ff4c339622c236202ec65d0/src/main/perf/SearchTask.java#L261-L352) to test performance of the new API, while for existing facets module it is [only two lines](https://github.com/mikemccand/luceneutil/blob/dac76d58c579bf440ff4c339622c236202ec65d0/src/main/perf/SearchTask.java#L403-L404). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
