stefanvodita commented on code in PR #14237:
URL: https://github.com/apache/lucene/pull/14237#discussion_r1956459385
##########
lucene/demo/src/java/org/apache/lucene/demo/facet/SandboxFacetsExample.java:
##########
@@ -130,6 +135,88 @@ void index() throws IOException {
IOUtils.close(indexWriter, taxoWriter);
}
+ /**
+ * Example for {@link FacetBuilder} usage - simple API that provides results
in a format very
+ * similar to classic facets module. It doesn't give all flexibility
available with {@link
Review Comment:
This really does look more familiar! Can we highlight it somewhere more
prominent as well? Maybe in the faceting guide.
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/utils/BaseFacetBuilder.java:
##########
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.sandbox.facet.utils;
Review Comment:
Should we have a package for the facet builders?
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/utils/CommonFacetBuilder.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.lucene.sandbox.facet.utils;
+
+import java.io.IOException;
+import org.apache.lucene.sandbox.facet.cutters.FacetCutter;
+import org.apache.lucene.sandbox.facet.labels.OrdToLabel;
+
+/**
+ * Common {@link FacetBuilder} that works with any {@link FacetCutter} and
{@link OrdToLabel}
+ * provided by user.
+ */
+public final class CommonFacetBuilder extends
BaseFacetBuilder<CommonFacetBuilder> {
+
+ private final FacetCutter cutter;
+ private final OrdToLabel ordToLabel;
+
+ public CommonFacetBuilder(String dimension, FacetCutter cutter, OrdToLabel
ordToLabel) {
+ super(dimension);
+ this.cutter = cutter;
+ this.ordToLabel = ordToLabel;
+ }
+
+ @Override
+ FacetCutter createFacetCutter() {
Review Comment:
Would it be a problem that this is called `create`, giving the impression
that we get a new cutter? Reusing the old one could be problematic, couldn't
it, if the user expects a new cutter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
