jimczi commented on code in PR #14215:
URL: https://github.com/apache/lucene/pull/14215#discussion_r1947267621
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##########
@@ -216,7 +216,7 @@ void searchLevel(
while (candidates.size() > 0 && results.earlyTerminated() == false) {
// get the best candidate (closest or best scoring)
float topCandidateSimilarity = candidates.topScore();
- if (topCandidateSimilarity < minAcceptedSimilarity) {
+ if (minAcceptedSimilarity > topCandidateSimilarity) {
Review Comment:
Right, that should be the inverse of
https://github.com/apache/lucene/pull/14215/files#diff-ba3b6b03fc9c4dde56640064013726c8d5334076a6f8622c5f9eaee048b4ad47R237
To make it less ambiguous I wonder if
`KnnCollector#minCompetitiveSimilarity` should be
`Math.nextUp(minimumHeapScore)` like we do for top hits collectors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
