shubhamvishu commented on code in PR #14215: URL: https://github.com/apache/lucene/pull/14215#discussion_r1947219947
########## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ########## @@ -216,7 +216,7 @@ void searchLevel( while (candidates.size() > 0 && results.earlyTerminated() == false) { // get the best candidate (closest or best scoring) float topCandidateSimilarity = candidates.topScore(); - if (topCandidateSimilarity < minAcceptedSimilarity) { + if (minAcceptedSimilarity > topCandidateSimilarity) { Review Comment: ++ I think this was supposed to be `>=` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org