tteofili commented on code in PR #14215:
URL: https://github.com/apache/lucene/pull/14215#discussion_r1951068471
##########
lucene/core/src/java/org/apache/lucene/search/TopKnnCollector.java:
##########
@@ -52,7 +52,7 @@ public boolean collect(int docId, float similarity) {
@Override
public float minCompetitiveSimilarity() {
- return queue.size() >= k() ? queue.topScore() : Float.NEGATIVE_INFINITY;
+ return queue.size() >= k() ? Math.nextUp(queue.topScore()) :
Float.NEGATIVE_INFINITY;
Review Comment:
> I am fine with that as well. I suppose the only thing that actually uses
this is the graph searcher :/
we now possibly have multiple class for graph searchers (extensions of
`AbstractHnswGraphSearcher`), but much better than going over all of the
`KnnCollectors`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
