mayya-sharipova commented on PR #14154: URL: https://github.com/apache/lucene/pull/14154#issuecomment-2610017660
@benwtrent Thanks for the review, I am not happy with the design either, will see how I can incorporate your feedback. > I don't like that CompletionAnalyzer needs to track a thread-local, the point of reuse strategy is to avoid this kind of thing. Also I'm not sure I understand why CompletionAnalyzer is different from other analyzer wrappers? @jpountz Thanks for looking. The idea of having an extra thread-local is for AnalyzerWrapper to keep track of `wrappedComponents`, but may be it doesn't need to be thread-local and can be just a local variable. You are right, `CompletionAnalyzer` is not different from other analyzer wrappers, and I can extend this policy to all AnalyzerWrapper. `CompletionAnalyzer` is where we experienced a problem in Elasticsearch, where it did not respect a reuse policy of the wrapped analyzer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
