jpountz commented on PR #14154: URL: https://github.com/apache/lucene/pull/14154#issuecomment-2649385716
I don't feel good about this change (at least not yet). It looks like there is an analyzer that changes its components over time somewhere, and this change aims at making sure that an analyzer that wrap this analyzer would also update its components. I worry that this is just one place where the assumption that analysis components are immutable is violated, and that there are other ones that haven't been found yet. I'm curious if other alternatives were considered, e.g. atomically swapping the analyzer or updating the behavior of analysis components without needing to replace them. For reference, a side-effect of this change is that analysis components are now cached both on the wrapper and on the wrapped analyzer, while they were only cached on the wrapper before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
