ChrisHegarty commented on code in PR #14119:
URL: https://github.com/apache/lucene/pull/14119#discussion_r1908398587
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java:
##########
@@ -256,7 +256,7 @@ public DocIndexIterator iterator() {
@Override
public Bits getAcceptOrds(Bits acceptDocs) {
- return null;
+ return new Bits.MatchNoBits(0);
Review Comment:
pedantically, shouldn't this return null for a null input?
```
if (acceptDocs == null) {
return null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
