vigyasharma opened a new pull request, #14119: URL: https://github.com/apache/lucene/pull/14119
EmptyOffHeapVectorValues currently returns null for `getAcceptOrds()`. However, internally across the codebase, we assume that null `Bits` imply that all values are accepted – like null for `acceptDocs()` or live docs. Since EmptyOffHeapVectorValues have not vectors, they should really reject all ordinals. This doesn't have much impact because I don't see much usage of Empty VectorValues. But it's good to clean up and keep assumptions consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
