uschindler commented on code in PR #13950:
URL: https://github.com/apache/lucene/pull/13950#discussion_r1888404168
##########
lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java:
##########
@@ -136,7 +152,7 @@ public List<BooleanClause> clauses() {
}
/** Return the collection of queries for the given {@link Occur}. */
- Collection<Query> getClauses(Occur occur) {
+ public Collection<Query> getClauses(Occur occur) {
return clauseSets.get(occur);
Review Comment:
Whenever you add getters for collections, make sure to make the unmodifiable
(either before or clone them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
