jpountz commented on code in PR #13950:
URL: https://github.com/apache/lucene/pull/13950#discussion_r1815173658
##########
lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java:
##########
@@ -136,20 +158,20 @@ public List<BooleanClause> clauses() {
}
/** Return the collection of queries for the given {@link Occur}. */
- Collection<Query> getClauses(Occur occur) {
+ public Collection<Query> getClauses(Occur occur) {
return clauseSets.get(occur);
}
/**
* Whether this query is a pure disjunction, ie. it only has SHOULD clauses
and it is enough for a
* single clause to match for this boolean query to match.
*/
- boolean isPureDisjunction() {
+ public boolean isPureDisjunction() {
return clauses.size() == getClauses(Occur.SHOULD).size() &&
minimumNumberShouldMatch <= 1;
}
/** Whether this query is a two clause disjunction with two term query
clauses. */
- boolean isTwoClausePureDisjunctionWithTerms() {
+ public boolean isTwoClausePureDisjunctionWithTerms() {
Review Comment:
I can understand why someone would want to make `getClauses` public, but I
wouldn't make the two above methods public, these are just implementation
details of some rewrite rules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
