shubhamvishu commented on PR #13950: URL: https://github.com/apache/lucene/pull/13950#issuecomment-2436351224
Thanks everyone for taking a look! As per comments the `#isPureDisjunction` and `#isTwoClausePureDisjunctionWithTerms` seems to be the debatable ones : - About `#isTwoClausePureDisjunctionWithTerms`, I'm myself not super convinced considering its targeting a very specific type of query and I agree it might only be useful in rewrite optimizations. Its good to have these helper functions but since it only has one usage(same for `#isPureDisjunction`) currently prolly keeping it more local to the only usage is better than in highly visible class like `BooleanQuery` (but then it loses the chance of being visible and reused :) ). Anyways I'll remove it. - `#isPureDisjunction` does seem and also sound more generic/useful comparatively to above one but I'm not able to think of any specific use case generic enough to convince exposing(though there maybe one for this). I removed these 2 for now and fixed the comments. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
