gsmiller commented on code in PR #13972: URL: https://github.com/apache/lucene/pull/13972#discussion_r1826037886
########## lucene/core/src/java/org/apache/lucene/codecs/lucene101/Lucene101PostingsReader.java: ########## @@ -601,7 +599,7 @@ public int advance(int target) throws IOException { } } - int next = VECTOR_SUPPORT.findNextGEQ(docBuffer, docBufferSize, target, docBufferUpto); + int next = VectorUtil.findNextGEQ(docBuffer, target, docBufferUpto, docBufferSize); Review Comment: @jpountz I made this change so that everything goes through `VectorUtil` and the `assert`. It also seemed a little more consistent with how we leverage `VectorUtil` vs. `VectorUtilSupport` elsewhere, but I'm not sure if you had a good reason for writing it the way you did. If there's a performance (or other) consideration here, I'd be happy to understand that better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org