javanna commented on code in PR #13971:
URL: https://github.com/apache/lucene/pull/13971#discussion_r1825756810
##########
lucene/core/src/java/org/apache/lucene/util/IntArrayDocIdSet.java:
##########
@@ -34,23 +34,15 @@ public final class IntArrayDocIdSet extends DocIdSet {
private final int[] docs;
private final int length;
- /**
- * Build an IntArrayDocIdSet by an int array and len.
- *
- * @param docs A docs array whose length need to be greater than the param
len. It needs to be
- * sorted from 0(inclusive) to the len(exclusive), and the len-th doc in
docs need to be
- * {@link DocIdSetIterator#NO_MORE_DOCS}.
- * @param len The valid docs length in array.
- */
- public IntArrayDocIdSet(int[] docs, int len) {
- if (docs[len] != DocIdSetIterator.NO_MORE_DOCS) {
+ public IntArrayDocIdSet(int[] docs, int length) {
Review Comment:
@jpountz this class used to be package private. With the revert that this PR
applies to main, `TestBooleanOr` would be the only caller of this constructor
outside of `o.a.l.util`, requiring it to be public. That looks odd, any chance
we could update `TestBooleanOr` to not rely on this class being public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
