jpountz commented on code in PR #13972: URL: https://github.com/apache/lucene/pull/13972#discussion_r1827331927
########## lucene/core/src/java/org/apache/lucene/codecs/lucene101/Lucene101PostingsReader.java: ########## @@ -601,7 +599,7 @@ public int advance(int target) throws IOException { } } - int next = VECTOR_SUPPORT.findNextGEQ(docBuffer, docBufferSize, target, docBufferUpto); + int next = VectorUtil.findNextGEQ(docBuffer, target, docBufferUpto, docBufferSize); Review Comment: I did it this way after doing something similar with PostingDecodingUtil, which didn't really belong to `VectorUtil`. I agree it's nicer the way you did it, I would not expect performance implications if inlining works properly, nightly benchmarks will tell us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org