jpountz commented on code in PR #13907:
URL: https://github.com/apache/lucene/pull/13907#discussion_r1801048564
##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInput.java:
##########
@@ -567,7 +567,8 @@ public final MemorySegmentIndexInput slice(String
sliceDescription, long offset,
public final MemorySegmentIndexInput slice(
String sliceDescription, long offset, long length, ReadAdvice advice)
throws IOException {
MemorySegmentIndexInput slice = slice(sliceDescription, offset, length);
- if (NATIVE_ACCESS.isPresent()) {
+ if (NATIVE_ACCESS.isPresent() && advice != ReadAdvice.NORMAL) {
Review Comment:
If we want to do some tricks for merging, I think we'll have to do something
like that. For CFS files, opening the compound file handle with a NORMAL advice
felt like the right thing to do.
##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInput.java:
##########
@@ -567,7 +567,8 @@ public final MemorySegmentIndexInput slice(String
sliceDescription, long offset,
public final MemorySegmentIndexInput slice(
String sliceDescription, long offset, long length, ReadAdvice advice)
throws IOException {
MemorySegmentIndexInput slice = slice(sliceDescription, offset, length);
- if (NATIVE_ACCESS.isPresent()) {
+ if (NATIVE_ACCESS.isPresent() && advice != ReadAdvice.NORMAL) {
Review Comment:
If we want to do some tricks for merging, I think we'll have to do something
like that indeed. For CFS files, opening the compound file handle with a NORMAL
advice felt like the right thing to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
