javanna commented on code in PR #13907: URL: https://github.com/apache/lucene/pull/13907#discussion_r1831341142
########## lucene/core/src/java/org/apache/lucene/codecs/CompoundFormat.java: ########## @@ -35,8 +35,8 @@ protected CompoundFormat() {} // we can add 'producer' classes. /** Returns a Directory view (read-only) for the compound files in this segment */ - public abstract CompoundDirectory getCompoundReader( - Directory dir, SegmentInfo si, IOContext context) throws IOException; + public abstract CompoundDirectory getCompoundReader(Directory dir, SegmentInfo si) Review Comment: Heya, just raising that this specific change requires adjusting consumers code when upgrading to Lucene 10.1. This class is marked experimental so I think we are good, but I thought it's worth double checking just to make sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org