easyice commented on PR #13825: URL: https://github.com/apache/lucene/pull/13825#issuecomment-2378508188
> I understand what the intention is here, @easyice , but this is the problem - you can't override that public method anymore and you can't call the protected method in a delegate class. I sort of agree with Robert that code duplication here is not worth the added API complexity. I suggest we remove the final modifier from that method first, then think of maybe dropping the protected method altogether (although this doesn't bother me as much, since it's protected). +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
