rmuir commented on PR #13825: URL: https://github.com/apache/lucene/pull/13825#issuecomment-2378011284
> Yes, this would also solve the problem. I wonder if it makes sense to expose that protected method though, if it's internal details of the implementation? I'd rather make the primary API method public and let subclasses do whatever they want with it (delegate, reimplement, etc.) I don't understand why there are 2 methods in the first place. There's a little bit of docs on the `final` one, but the `protected` one is basically undocumented. Seems a bit convoluted. IMO one single, well-documented, public method would be a better fit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
