dweiss commented on PR #13825: URL: https://github.com/apache/lucene/pull/13825#issuecomment-2377881935
> Isn't the root cause of the issue the `protected` method? The `final` method just invokes other methods, so alternatively we could fix the visibility of the protected method to be public like all the others? Yes, this would also solve the problem. I wonder if it makes sense to expose that protected method though, if it's internal details of the implementation? I'd rather make the primary API method public and let subclasses do whatever they want with it (delegate, reimplement, etc.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
