jpountz commented on code in PR #13757:
URL: https://github.com/apache/lucene/pull/13757#discussion_r1754494565


##########
lucene/core/src/java/org/apache/lucene/search/similarities/Similarity.java:
##########
@@ -111,7 +144,17 @@ protected Similarity() {}
    * @param state current processing state for this field
    * @return computed norm value
    */
-  public abstract long computeNorm(FieldInvertState state);
+  public long computeNorm(FieldInvertState state) {
+    final int numTerms;
+    if (state.getIndexOptions() == IndexOptions.DOCS && 
state.getIndexCreatedVersionMajor() >= 8) {

Review Comment:
   since we don't support writing version < 8 anyway, you could assume that 
`state.getIndexCreatedVersionMajor() >= 8` is always true now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to