cpoerschke commented on PR #13757:
URL: https://github.com/apache/lucene/pull/13757#issuecomment-2343503906

   > I would also be in favor of adding some kind of warning/note, to the 
`computeNorm`: "expert: if you change this, index will not be different and not 
compatible with other similarities/require reindexing to change" and to the 
constructor taking the bool?
   
   Generally I like the idea of more context but am not sure how to make it 
very very clear e.g. when we say "if you change this" does that mean 
overriding-the-method or 
overriding-the-method-and-then-using-the-similarity-with-the-override-with-a-field-that-previously-used-the-original-similarity-to-use-the-custom-similarity
 or something else? Likewise when we say "not compatible/require reindexing" - 
is that works-but-gives-wrong-results or does-not-work-and-throws-exceptions or 
a variation of the two?
   
   If (perhaps) there is a general assumption of "you cannot change the 
similarity of an existing field" and "similarity (and some other) changes 
require reindexing" then probably I would favour not having warnings or notes 
that convey that in some circumstances some changes can be compatible and don't 
require reindexing.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to