cpoerschke commented on PR #13757: URL: https://github.com/apache/lucene/pull/13757#issuecomment-2343469863
> I'm still investigating w.r.t. some subclasses having setters and how that would interact with the constructor taking a boolean too. https://github.com/apache/lucene/pull/13757/commits/91cfd5e512354f19bf9e7499b5e9629ef663b7bd is to have the flag and accessors in the base class, that's okay I think so long as the accessors are final (and the flag has private visibility). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
