cpoerschke commented on code in PR #13635: URL: https://github.com/apache/lucene/pull/13635#discussion_r1707338145
########## lucene/core/src/java/org/apache/lucene/search/KnnByteVectorQuery.java: ########## @@ -72,14 +72,30 @@ public KnnByteVectorQuery(String field, byte[] target, int k) { * @throws IllegalArgumentException if <code>k</code> is less than 1 */ public KnnByteVectorQuery(String field, byte[] target, int k, Query filter) { - super(field, k, filter); + this(field, target, k, filter, null); + } + + /** + * Find the <code>k</code> nearest documents to the target vector according to the vectors in the + * given field. <code>target</code> vector. + * + * @param field a field that has been indexed as a {@link KnnFloatVectorField}. Review Comment: ```suggestion * @param field a field that has been indexed as a {@link KnnByteVectorField}. ``` copy/paste from existing line 68 above -- #13637 for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org