benwtrent commented on code in PR #13635: URL: https://github.com/apache/lucene/pull/13635#discussion_r1705418758
########## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ########## @@ -156,6 +189,44 @@ private TopDocs getLeafResults( } } + private DocIdSetIterator executeSeedQuery(LeafReaderContext ctx, Weight seedWeight) Review Comment: Also, at a minimum, we would need to make sure that the seed docs have the vector field. It is possible (actually rather likely), that the query actually doesn't match any docs that contain vectors, then the down stream translation from docId -> vector ordinal completely fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org