javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1695857209
##########
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##########
@@ -362,6 +362,9 @@ public long cost() {
final IntersectVisitor visitor = getIntersectVisitor(result);
long cost = -1;
+ // maybe allowing calling get multiple times, or clone the scorer
to avoid duplication
+ // across multiple
+ // slices that point to the same segment
Review Comment:
I went back and forth on this: I updated `TestSortRandom` to succeed against
segment partitions, by updating its `ScorerSupplier` implementation to not rely
on the fact that the scorer supplier is pulled once per `LeafReaderContext`.
There is a fair amount of work to do on removing duplication across partitions,
but I propose that we address that as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
