javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1695912482
##########
lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java:
##########
@@ -146,114 +146,123 @@ private IndexSearcher getNewSearcher(IndexReader
reader) {
// DrillSideways requires the entire range of docs to be scored at once,
so it doesn't support
// timeouts whose implementation scores one window of doc IDs at a time.
searcher.setTimeout(null);
+ assumeFalse(
+ "Does not support intra-segment concurrency",
+ IndexSearcher.hasLeafPartitions(searcher.getSlices()));
return searcher;
}
// See LUCENE-10060:
public void testNoCaching() throws Exception {
Directory dir = newDirectory();
Directory taxoDir = newDirectory();
-
RandomIndexWriter writer = new RandomIndexWriter(random(), dir);
DirectoryTaxonomyWriter taxoWriter =
new DirectoryTaxonomyWriter(taxoDir,
IndexWriterConfig.OpenMode.CREATE);
+ IndexReader reader = null;
+ TaxonomyReader taxoReader = null;
+ try {
+ FacetsConfig config = new FacetsConfig();
Review Comment:
all of the diff noise in the facet tests are due to adding finally blocks to
close all dirs, readers and writers. Those are important as the assumeFalse may
make the test terminate ahead of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
