epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693085716
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/RangeFacetCutter.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.sandbox.facet.cutters.ranges; + +import org.apache.lucene.facet.range.DoubleRange; +import org.apache.lucene.facet.range.LongRange; +import org.apache.lucene.sandbox.facet.cutters.FacetCutter; +import org.apache.lucene.util.NumericUtils; + +/** {@link FacetCutter} for ranges * */ +public abstract class RangeFacetCutter implements FacetCutter { + // TODO: we don't always have field, e.g. for custom DoubleValuesSources - let's remove it from + // here? + String field; + + // TODO: make the constructor also take in requested value sources and ranges + // Ranges can be done now, we need to make a common interface for ValueSources + RangeFacetCutter(String field) { + this.field = field; + } + + LongRange[] mapDoubleRangesToSortableLong(DoubleRange[] doubleRanges) { + LongRange[] longRanges = new LongRange[doubleRanges.length]; + for (int i = 0; i < longRanges.length; i++) { + DoubleRange dr = doubleRanges[i]; + longRanges[i] = + new LongRange( + dr.label, + NumericUtils.doubleToSortableLong(dr.min), + true, + NumericUtils.doubleToSortableLong(dr.max), + true); Review Comment: I believe it works correctly because `DoubleRange` class doesn't have inclusive/exclusive attributes, instead it calls `minIn = Math.nextUp(minIn)` and `maxIn = Math.nextAfter(maxIn, Double.NEGATIVE_INFINITY);` to make min and max always inclusive. On a side note, the method copy-pasted from `protected DoubleRangeFacetCounts#getLongRanges`, I'm adding a TODO to dedup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
