MilindShyani commented on issue #13519: URL: https://github.com/apache/lucene/issues/13519#issuecomment-2232355996
The math is quite simple as we saw above, but the code (I guess because its trying to do 7 and 8 bits at the same time) is giving me a really hard time 😅 How is the quadratic term being calculated? Is it `dx_q * dy_q` using the new definition of `_q `variables or using the old? Recall that old definition is `dx_q = Math.round(dx*scale - c) * alpha ` while the old definition was `dx_q = Math.round(dx*scale) * alpha ` In any case, you have worked with the code far longer than I have, so if you are confident about it please go ahead and commit :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
