MilindShyani commented on issue #13519: URL: https://github.com/apache/lucene/issues/13519#issuecomment-2224005032
Hello! So I just did the calculation and I get the following 1) I get an innocuous sign discrepancy, i.e., the term `- SIGNED_CORRECTION * alpha` should instead be `+SIGNED_CORRECTION * alpha` I will double check this. 2) I get an extra term. This is rather serious since it would also affect the unsigned math. My correction looks like `(dx - dxq)*(dxq + \alpha * c + \alpha * min_quantile)` The last term is the extra term, which is present even when c = Signed_correction = 0. What do you think of the extra term @benwtrent ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org