uschindler commented on PR #13535: URL: https://github.com/apache/lucene/pull/13535#issuecomment-2210600762
I am not really sure how we should proceed. The `new SegmentReader()` which is closed a few lines below looks like a valid use case for READ_ONLY, but SegmentReader creates clones. - damn! Not sure how we should handle that. Maybe let's remove disallowing of clones and slices, but check that the threads are correct. @jpountz ? About the CFS files we should really look if we can't get a "better way" to only request a single file from a huge CFS. But this is just an observation we have seen here and has nothing to do with this isse: It seems very bad to mmap a whole huge CFS file just to extract one child file from it in an readonce context. This is an idea for another issue to refactor the CFS Directory to better work with an underlying index input and maybe allow to mmap only slices from begining. This is more complicated to implement but might be worth to look into. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
